Adds the missing 'thin: true' parameter in the StorageClass example #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhaashish
approved these changes
Mar 5, 2024
|
@peuh Can you please sign your commit |
Signed-off-by: Lisa <[email protected]>
…cted by ConfigMap Signed-off-by: Lisa <[email protected]>
tiagolobocastro
approved these changes
Mar 5, 2024
tiagolobocastro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mayastor StorageClass documentation says that the provided samples have thin provisioning enabled, but the thin=true parameter is not provided and the StorageClass reference (here: https://mayastor.gitbook.io/introduction/quickstart/configure-mayastor/storage-class-parameters#thin) indicates that the default is thick provisioning.
This PR adds the thin parameter to the example